Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.3.0] Disable ImpossibleNullComparison #18405

Closed
wants to merge 1 commit into from
Closed

[6.3.0] Disable ImpossibleNullComparison #18405

wants to merge 1 commit into from

Conversation

keertk
Copy link
Member

@keertk keertk commented May 15, 2023

Disable ImpossibleNullComparison to fix failing presubmits in 6.3

E.g. https://buildkite.com/bazel/bazel-bazel-github-presubmit/builds/15828#01881e5d-4e13-458d-adbf-c1d0659f4198

Commit f4b35a2

PiperOrigin-RevId: 532157602
Change-Id: I8e64b9774a83d55894bf63661a10a7faf1ca69cf

@keertk
Disable ImpossibleNullComparison
c495676 
PiperOrigin-RevId: 532157602
Change-Id: I8e64b9774a83d55894bf63661a10a7faf1ca69cf
@keertk keertk added team-Rules-Java Issues for Java rules awaiting-review PR is awaiting review from an assigned reviewer labels May 15, 2023
@keertk keertk requested review from cushon and meteorcloudy May 15, 2023 18:17
@keertk
Copy link
Member Author

keertk commented May 15, 2023 •
edited
Loading

@cushon @hvadehra is this what needs to be cherry-picked? Or does this require a new java tools release as well?

@meteorcloudy
Copy link
Member

meteorcloudy commented May 16, 2023 •
edited
Loading

@keertk Since the breakage is from ParallelVisitorTest.java, but it's not failing with Bazel@HEAD, then there must be some change at HEAD that fixes this issue. So I checked the history of this test and found this commit:
83d0f2c

You can probably fix the issue by cherry picking this one.

@keertk keertk closed this May 16, 2023
@keertk keertk mentioned this pull request May 16, 2023
Merged
@keertk keertk mentioned this pull request May 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cushon cushon Awaiting requested review from cushon

@meteorcloudy meteorcloudy Awaiting requested review from meteorcloudy

Assignees
No one assigned
Labels
awaiting-review PR is awaiting review from an assigned reviewer team-Rules-Java Issues for Java rules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@keertk @meteorcloudy